Change anypb.Any to emptypb.Empty (thanks @danw for the fix)#57
Open
ntaylor-barnett wants to merge 1 commit intomwitkow:masterfrom
Open
Change anypb.Any to emptypb.Empty (thanks @danw for the fix)#57ntaylor-barnett wants to merge 1 commit intomwitkow:masterfrom
ntaylor-barnett wants to merge 1 commit intomwitkow:masterfrom
Conversation
|
In my case, also need fix L147 |
smoole
added a commit
to smoole/grpc-proxy
that referenced
this pull request
Apr 28, 2022
|
Is this fix from anypb to emptypb will be merged to main branch. If fixes the invalid utf-8 error when response is received from grpc-proxy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a issue that was picked up in some of my own unit tests for a separate project. Thanks danw for the workaround. I don't know for sure if this will cause problems for other people, but it got it all working perfectly in my use cases.
#55 (comment)